Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(csharp/src/Drivers/Apache): convert Double to Float for Apache Spark on scalar conversion #2296

Merged
merged 3 commits into from
Nov 1, 2024
Merged

feat(csharp/src/Drivers/Apache): convert Double to Float for Apache Spark on scalar conversion #2296

merged 3 commits into from
Nov 1, 2024
+47 −13

Conversation

birschick-bq
Copy link
Contributor

If Apache Spark server indicates the host data type is FLOAT, and the scalar data type conversion is selected, convert Double array to Float array.

  • Performs conversion as prescribed
  • Updates tests
  • Corrects SQL statement for older versions of Spark server.

@github-actions github-actions bot added this to the ADBC Libraries 15 milestone Nov 1, 2024
@birschick-bq birschick-bq marked this pull request as draft November 1, 2024 00:14
@birschick-bq birschick-bq marked this pull request as ready for review November 1, 2024 00:18
CurtHagenlocher
CurtHagenlocher requested changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@CurtHagenlocher CurtHagenlocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change! I've made one small suggestion for a performance improvement that I think would be good to make.

csharp/src/Drivers/Apache/Hive2/HiveServer2Reader.cs Show resolved Hide resolved
CurtHagenlocher
CurtHagenlocher approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@CurtHagenlocher CurtHagenlocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@CurtHagenlocher CurtHagenlocher merged commit e46abba into apache:main Nov 1, 2024
6 checks passed
@birschick-bq birschick-bq deleted the dev/birschick-bq/convert-to-float branch November 1, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CurtHagenlocher CurtHagenlocher CurtHagenlocher approved these changes

@lidavidm lidavidm Awaiting requested review from lidavidm lidavidm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ADBC Libraries 15
Development

Successfully merging this pull request may close these issues.
2 participants
@birschick-bq @CurtHagenlocher