fix(rust)!: Let immutable drivers create connections #2788
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the removal of the global driver lock, there is no risk of deadlocks between the locks on the driver and on the database objects.
IIUC, this was why member functions on the database struct took a mutable
selfparameter:Requiring
&mut selfis overkill and requires another layer of locking at the application side if multiple threads share a database instance (as they should for connection pooling).This doesn't mean we are passing a forged mutable pointer to the driver via the FFI, the locking on the inner database ensures exclusive access to the
FFI_AdbcDatabase.This might be considered a breaking change.
Closes #2790