- 
                Notifications
    
You must be signed in to change notification settings  - Fork 161
 
feat(go/adbc/driver): initial tracing instrumentation for Snowflake driver #2825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(go/adbc/driver): initial tracing instrumentation for Snowflake driver #2825
Conversation
| 
           @davidhcoe  | 
    
| 
           @zeroshade - Matt Just made a couple of small changes to ensure the error is set correctly before returning from functions, so that tracing has the correct error instance.  | 
    
| 
           Note that snowflakedb/gosnowflake@d092186 (which is in 1.14.1 that I just merged) adds OTel to the Snowflake SDK, if we can confirm this works with that  | 
    
          
 Working on it. Thanks.  | 
    
          
 Yes. I confirmed it is working as expected  | 
    
…strumentation for database
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@zeroshade any comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a small couple of nitpicks, but otherwise this is looking great to me!
| 
           @zeroshade Matt - addressed the two PR comments. Let me know if there is anything else to address. Thanks!  | 
    
| 
           @birschick-bq - can you resolve the conflicts then get this merged ASAP?  | 
    
          
 @davidhcoe Done  | 
    
| 
           @zeroshade - If good to go, can we get this merged? Thanks.  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!

Includes some improvements to ease instrumentation
Instrumentation for the Snowflake driver.
Example