Skip to content

Conversation

@WillAyd
Copy link
Contributor

@WillAyd WillAyd commented May 22, 2025

No description provided.

@WillAyd WillAyd requested a review from lidavidm as a code owner May 22, 2025 17:16
@github-actions github-actions bot added this to the ADBC Libraries 19 milestone May 22, 2025
@WillAyd
Copy link
Contributor Author

WillAyd commented May 22, 2025

This was discovered by user @IIFE in #2846 (comment)

We don't test our Meson configuration on Windows in CI (maybe we should ?) so we aren't getting coverage in the current state, but this is a pattern that I've seen projects use in Meson's wrapdb before

Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. We could/should probably test

@lidavidm lidavidm merged commit 2cccd56 into apache:main May 23, 2025
69 checks passed
@WillAyd WillAyd deleted the no-dl-on-windows branch May 23, 2025 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants