fix(csharp/src/Drivers/Apache): improve metadata query handling #2926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove underscore escaping for exact match queries in Hive driver - Fix cross-reference handling in Databricks driver to check both catalogs - Update tests to handle different integer types in FK_INDEX column - Add implementation for foreign key table creation in Databricks tests
eric-wang-1990
changed the title
- Override CreateNewTableName in Databricks tests to include special characters - Fix comment formatting in Apache Common tests
eric-wang-1990
changed the title
CurtHagenlocher
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve metadata query handling in C# drivers
Summary
This PR makes several improvements to metadata query handling in the C# drivers:
Motivation
The current implementation incorrectly escapes underscores in exact match queries, which can lead to incorrect results when querying metadata for tables with underscores in their names. Additionally, the Databricks driver was not properly handling cross-references when one catalog was valid but the other was invalid.
The added special character handling in tests ensures that our drivers correctly handle table names with special characters, which is important for real-world scenarios.
Testing