Skip to content

chore(r): fix typo #2975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2025
Merged

chore(r): fix typo #2975

merged 1 commit into from
Jun 19, 2025

Conversation

@daipom
Copy link
Contributor

@daipom daipom commented Jun 16, 2025

Fixed only error messages.

Closes #2974

@daipom daipom requested a review from paleolimbot as a code owner June 16, 2025 09:39
@github-actions github-actions bot added this to the ADBC Libraries 19 milestone Jun 16, 2025
@daipom
Copy link
Contributor Author

daipom commented Jun 16, 2025

CI fails with:

tools/test_extension.c:21:29: warning: 'sqlite3_auto_extension' is deprecated: first deprecated in macOS 10.10 - Process-global auto extensions are not supported on Apple platforms [-Wdeprecated-declarations]

Looks like it has nothing to do with this fix.

@daipom
Copy link
Contributor Author

daipom commented Jun 18, 2025

About failing CI:

lidavidm
lidavidm approved these changes Jun 19, 2025
View reviewed changes
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given these are typo fixes, I'm going to go ahead and merge this; it looks like Dewey will examine what's going on with the build separately

@lidavidm lidavidm merged commit fd85000 into apache:main Jun 19, 2025
18 of 27 checks passed
@daipom daipom deleted the chore-r-fix-typo branch June 19, 2025 07:54
@daipom
Copy link
Contributor Author

daipom commented Jun 19, 2025

Thanks!

@serramatutu serramatutu mentioned this pull request Aug 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidavidm lidavidm lidavidm approved these changes

@paleolimbot paleolimbot Awaiting requested review from paleolimbot paleolimbot is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

ADBC Libraries 19

Development

Successfully merging this pull request may close these issues.

chore(r): fix typo

2 participants

@daipom @lidavidm