fix(go/adbc): changing the location of FlightSQLDriverInit function

[howareyouman]

Moving FlightSQLDriverInit function to a separate go file.
Resolving the request from the recent PR - link

[zeroshade]

@howareyouman the driver.go is also generated by code generation, with the goal of avoiding losing the functions during code-gen it needs to be a separate file from driver.go/utils.c/utils.h

[howareyouman]

@zeroshade I see that these 2 functions heavily rely on C layer, which lives in the pkg folder, and the dependency between folders is pkg(generated) -> driver(not generated).

I don't understand how to remove them from the generation step if we want to expose them in the shared library, and they rely on generated code? What should be done here then?

[zeroshade]

The generation doesn't remove and recreate the directory, we just create the files. So you can just make a new file in the pkg/flightsql directory which contains the functions. That way they don't get overwritten during generation, but are still part of the package that they rely on.

[howareyouman]

@zeroshade I've created new go file with functions, removed _tmpl generated files from the repo (I don't know why we had them in the repo?).

[zeroshade]

The tmpl files are in the repo so that we can use go generate to regenerate the files. We need them to be in the repo for the code generation. The flightsql package isn't the only one that we generate using it. It's a general purpose template for generating a C wrapper for an ADBC driver written in go.

Please restore those files as they are necessary. My suggestion was to leave the existing files as is and just add one new file containing the function we're adding back.

[howareyouman]

@zeroshade migrated FlightSQLDriverInit to new file

[davidhcoe]

@howareyouman - what does this need to close out by Wednesday (early US time)?

[howareyouman]

@davidhcoe I suppose I've already done what @zeroshade was asking for. The only problem is that we have CI failed, which I couldn't restart.

[zeroshade]

restarted the flaky test. This looks good to me