chore(csharp/test/Drivers/Databricks): Split the Databricks test into unit test and integration test #3095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackyhu-db
requested review from
CurtHagenlocher,
kou and
lidavidm
as code owners
jackyhu-db
force-pushed
the
databricks-test-restructure
branch
from
1f47f24 to
eeb0f1b
Compare
jackyhu-db
force-pushed
the
databricks-test-restructure
branch
from
eeb0f1b to
0437204
Compare
alexguo-db
approved these changes
Jul 3, 2025
CurtHagenlocher
requested changes
Jul 3, 2025
CurtHagenlocher
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Motivation
The tests under
csharp/test/Drivers/Databricksinclude both unit test and E2E test, and E2E test depends on the connection setup with Databricks and cannot (currently) be run by the CI/voter, but unit test does not have this dependency and should be run by the CI to detect code regression early. So we should restructure the tests into sub-folderUnitandE2E.Changes
csharp/test/Drivers/DatabricksintoUnitandE2EfolderApache.Arrow.Adbc.Tests.Drivers.Databricks.Unitas the root namespace for all the Databricks unit testci/scripts/csharp_test.shto include Databricks unit test so that it can be run by the CITesting
ci/scripts/csharp_test.shcsharp/test/Drivers/Databricks