Skip to content

fix(go/adbc/pkg): add PowerShell option to run when executing in a Windows-based ADO pipeline #3124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 10, 2025
Merged

fix(go/adbc/pkg): add PowerShell option to run when executing in a Windows-based ADO pipeline #3124

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da52f26
add Windows option; rearrange commands
Jul 9, 2025
5fd6b0b
PR feedback
Jul 10, 2025
8f5879a
tweak slightly
Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion go/adbc/pkg/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,13 @@ else
SUFFIX=dylib
Copy link
Member

@lidavidm lidavidm Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this omit macOS? Maybe there should be a separate ifeq windows [powershell] else [git]?

Copy link
Contributor Author

@davidhcoe davidhcoe Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. fixed.

endif

GIT_VERSION=$(shell git tag -l --points-at $(shell git rev-list --tags --max-count=1) --sort=-v:refname | head -n 1)
ifeq ($(shell go env GOOS),windows)
GIT_VERSION := $(shell powershell -Command "git tag --sort=-v:refname --points-at $$(git rev-list --tags --max-count=1) | Select-Object -First 1")
else
GIT_VERSION=$(shell git tag -l --points-at $(shell git rev-list --tags --max-count=1) --sort=-v:refname | head -n 1)
endif

GIT_VERSION ?= unknown
VERSION=$(subst go/adbc/,,$(GIT_VERSION))

# Expand dynamically libadbc_driver_.SUFFIX
Expand Down
Loading