Skip to content

fix(csharp/src/Drivers/Apache/Hive2): Remove unnecessary CloseOperation in Statement.Dispose when query is metadata query #3189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2025
Merged

fix(csharp/src/Drivers/Apache/Hive2): Remove unnecessary CloseOperation in Statement.Dispose when query is metadata query #3189

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b59c307
fix(csharp/src/Drivers/Hive2): Fix unnecessary CloseOperation for Met…
jackyhu-db Jul 22, 2025
e5b155a
Set directResult in GetCrossReferenceAsForeignTableAsync
jackyhu-db Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions csharp/src/Drivers/Apache/Hive2/HiveServer2Statement.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,6 +437,7 @@ protected virtual async Task<QueryResult> GetCrossReferenceAsForeignTableAsync(C
TableName,
cancellationToken);
OperationHandle = resp.OperationHandle;
_directResults = resp.DirectResults;

return await GetQueryResult(resp.DirectResults, cancellationToken);
}
Expand All @@ -457,6 +458,7 @@ protected virtual async Task<QueryResult> GetCrossReferenceAsync(CancellationTok
ForeignTableName,
cancellationToken);
OperationHandle = resp.OperationHandle;
_directResults = resp.DirectResults;

return await GetQueryResult(resp.DirectResults, cancellationToken);
}
Expand All @@ -474,6 +476,7 @@ protected virtual async Task<QueryResult> GetPrimaryKeysAsync(CancellationToken
TableName,
cancellationToken);
OperationHandle = resp.OperationHandle;
_directResults = resp.DirectResults;

return await GetQueryResult(resp.DirectResults, cancellationToken);
}
Expand All @@ -482,6 +485,7 @@ protected virtual async Task<QueryResult> GetCatalogsAsync(CancellationToken can
{
TGetCatalogsResp resp = await Connection.GetCatalogsAsync(cancellationToken);
OperationHandle = resp.OperationHandle;
_directResults = resp.DirectResults;

return await GetQueryResult(resp.DirectResults, cancellationToken);
}
Expand All @@ -493,6 +497,7 @@ protected virtual async Task<QueryResult> GetSchemasAsync(CancellationToken canc
EscapePatternWildcardsInName(SchemaName),
cancellationToken);
OperationHandle = resp.OperationHandle;
_directResults = resp.DirectResults;

return await GetQueryResult(resp.DirectResults, cancellationToken);
}
Expand All @@ -507,6 +512,7 @@ protected virtual async Task<QueryResult> GetTablesAsync(CancellationToken cance
tableTypesList,
cancellationToken);
OperationHandle = resp.OperationHandle;
_directResults = resp.DirectResults;

return await GetQueryResult(resp.DirectResults, cancellationToken);
}
Expand Down
Loading