Skip to content

fix(c/driver_manager): use Driver.entrypoint as per docs #3242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 6, 2025
Merged

fix(c/driver_manager): use Driver.entrypoint as per docs #3242

merged 4 commits into from
Aug 6, 2025

Conversation

@zeroshade
Copy link
Member

As per the docs the Driver manifest allows overriding the entrypoint via the Driver.entrypoint key. Rust follows this properly, but C++ checks for a top-level key named entrypoint instead of following the docs. This PR fixes this so that the C++ driver manager correctly looks for Driver.entrypoint.

@zeroshade zeroshade requested a review from lidavidm as a code owner August 6, 2025 20:43
@github-actions github-actions bot added this to the ADBC Libraries 20 milestone Aug 6, 2025
@zeroshade zeroshade requested review from amoeba and ianmcook August 6, 2025 20:43
@zeroshade zeroshade requested a review from paleolimbot August 6, 2025 21:00
paleolimbot
paleolimbot approved these changes Aug 6, 2025
View reviewed changes
Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

amoeba
amoeba approved these changes Aug 6, 2025
View reviewed changes
Copy link
Member

@amoeba amoeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, nice catch

@lidavidm lidavidm merged commit 16269af into apache:main Aug 6, 2025
87 checks passed
@zeroshade zeroshade deleted the driver-manager-entrypoint branch August 7, 2025 14:51
@serramatutu serramatutu mentioned this pull request Aug 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amoeba amoeba amoeba approved these changes

@lidavidm lidavidm lidavidm approved these changes

@paleolimbot paleolimbot paleolimbot approved these changes

@ianmcook ianmcook Awaiting requested review from ianmcook

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

ADBC Libraries 20

Development

Successfully merging this pull request may close these issues.

4 participants

@zeroshade @amoeba @lidavidm @paleolimbot