Skip to content

Conversation

@eitsupi
Copy link
Contributor

@eitsupi eitsupi commented Aug 11, 2025

It seems that CI has started to fail as a result of macos-latest changing from macos 14 to 15.

 [ 65%] Building CXX object driver/sqlite/CMakeFiles/adbc_driver_sqlite_objlib.dir/sqlite.cc.o
/Users/runner/work/arrow-adbc/arrow-adbc/c/driver/sqlite/sqlite.cc:718:16: error: use of undeclared identifier 'sqlite3_load_extension'
  718 |       int rc = sqlite3_load_extension(conn_, extension_path_.c_str(),
      |                ^
1 error generated.
make[2]: *** [driver/sqlite/CMakeFiles/adbc_driver_sqlite_objlib.dir/sqlite.cc.o] Error 1
make[1]: *** [driver/sqlite/CMakeFiles/adbc_driver_sqlite_objlib.dir/all] Error 2
make: *** [all] Error 2

I don't know why this error is occurring, but it looks like it can be avoided by making a change like #1259.

@eitsupi eitsupi force-pushed the rust-ci branch 2 times, most recently from 1339c08 to a977ccf Compare August 11, 2025 14:54
@eitsupi eitsupi marked this pull request as ready for review August 11, 2025 15:14
@github-actions github-actions bot added this to the ADBC Libraries 20 milestone Aug 11, 2025
@amoeba
Copy link
Member

amoeba commented Aug 11, 2025

In the CI log, it looks like it's finding the macOS version of sqlite but I thought we always need/want the homebrew version. I see this,

2025-08-11T14:57:00.1638800Z -- Found SQLite3: /Applications/Xcode_16.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.0.sdk/usr/include (found version "3.43.2")

The workflow sets up DYLD_LIBRARY_PATH correctly to handle brew sqlite but I don't see where it gets installed.

@eitsupi
Copy link
Contributor Author

eitsupi commented Aug 11, 2025

Thanks for looking at this.
Would it be better to install sqlite via Homebrew?
(Strangely, I don't see sqlite in the list of installed software on the macos-14 image either, so I don't know why this hasn't happened before.)

@lidavidm
Copy link
Member

I think this change is fine since the Rust test doesn't really need the extension loading.

@lidavidm lidavidm merged commit 5f301d3 into apache:main Aug 12, 2025
11 checks passed
@eitsupi eitsupi deleted the rust-ci branch August 12, 2025 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants