Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement vectorized hashing for dictionary types #331

Closed
Dandandan opened this issue May 12, 2021 · 0 comments · Fixed by #3445
Closed

Implement vectorized hashing for dictionary types #331

Dandandan opened this issue May 12, 2021 · 0 comments · Fixed by #3445
Labels
datafusion Changes in the datafusion crate enhancement New feature or request

Comments

@Dandandan
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Currently only primitive types and string types are supported as dictionary keys.
For hash join and hash aggregate we need to hash values.

Describe the solution you'd like
Implement dictionary type in create_hashes function.

Describe alternatives you've considered
n/a

Additional context
Dictionary types are supported for group by now via create_key_for_col. There is an explicit check on using hash repartitioning for dictionary keys in the physical planner. This check can be removed when dictionaries are supported in create_hashes.

@Dandandan Dandandan added the enhancement New feature or request label May 12, 2021
@alamb alamb added the datafusion Changes in the datafusion crate label May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants