Use hash repartitioning for aggregates on dictionaries #3445
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #331.
Rationale for this change
Hash repartitioning for aggregates on dictionaries was not available when it was initially implemented since dictionaries couldn't be hashed. The real issue in #331 (implementing vectorized hashing for dictionaries) is already resolved (by @alamb on #812), so as far as I can say we can safely remove this guard in the physical plan builder to leverage hash repartitioning on aggregates with dicts.
What changes are included in this PR?
Changes the physical plan builder to use hash repartitioning on dictionary-based aggregates.
Are there any user-facing changes?
This is an optimization, so there shouldn't be any behavioural change but the physical plans will change on some scenerios (like the example below).
Previous physical plan for the test
hash_agg_group_by_partitioned_on_dicts
:Current physical plan for it: