Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TPC-H Query 1 has regressed #3729

Closed
avantgardnerio opened this issue Oct 5, 2022 · 5 comments
Closed

TPC-H Query 1 has regressed #3729

avantgardnerio opened this issue Oct 5, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@avantgardnerio
Copy link
Contributor

Describe the bug

When running TPC-H query 1, this is the result:

2022-10-05 14:42:16,272 [2560011]   WARN - #c.i.d.d.BaseDatabaseErrorHandler$UnknownErrorInfo - Error while executing SQL "select l_returnflag, l_linestatus, sum(l_quantity) as sum_qty, sum(l_extendedprice) as sum_base_price,
    sum(l_extendedprice * (1 - l_discount)) as sum_disc_price,
    sum(l_extendedprice * (1 - l_discount) * (1 + l_tax)) as sum_charge, avg(l_quantity) as avg_qty,
    avg(l_extendedprice) as avg_price, avg(l_discount) as avg_disc, count(*) as count_order
from lineitem
where l_shipdate <= date '1998-09-02'
group by l_returnflag, l_linestatus
order by l_returnflag, l_linestatus": Error executing plan: Error planning job l6OLwA0: DataFusionError(Internal("The type of Timestamp(Nanosecond, None) <= Date32 of binary physical should be same"))
java.sql.SQLException: Error while executing SQL "select l_returnflag, l_linestatus, sum(l_quantity) as sum_qty, sum(l_extendedprice) as sum_base_price,
    sum(l_extendedprice * (1 - l_discount)) as sum_disc_price,
    sum(l_extendedprice * (1 - l_discount) * (1 + l_tax)) as sum_charge, avg(l_quantity) as avg_qty,
    avg(l_extendedprice) as avg_price, avg(l_discount) as avg_disc, count(*) as count_order
from lineitem
where l_shipdate <= date '1998-09-02'
group by l_returnflag, l_linestatus
order by l_returnflag, l_linestatus": Error executing plan: Error planning job l6OLwA0: DataFusionError(Internal("The type of Timestamp(Nanosecond, None) <= Date32 of binary physical should be same"))

To Reproduce

Run TPC-H query 1.

Expected behavior

A result is returned.

@avantgardnerio avantgardnerio added the bug Something isn't working label Oct 5, 2022
@alamb
Copy link
Contributor

alamb commented Oct 7, 2022

We have fixed a few bugs in this coercion area recently -- it "might" work if you try with latest master.

Now that we have the optimizer integration test, it would be great to at least get tests for all tpch querries into that

@avantgardnerio
Copy link
Contributor Author

I need to look into this again - @andygrove said he ran it and it worked. I think my schema inference may have picked the wrong data type for this timestamp and gotten different results.

@andygrove
Copy link
Member

Could be related to #3764

@alamb
Copy link
Contributor

alamb commented Oct 11, 2022

@andygrove has proposed an improvement to testing #3790

@Dandandan
Copy link
Contributor

tests::run_q1 is working on master (just confirmed). Hopefully when the TPC-H regression tests are there we can avoid errors creeping in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants