Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Benchmark regression tests #3790

Merged
merged 7 commits into from
Oct 11, 2022

Conversation

andygrove
Copy link
Member

Which issue does this PR close?

N/A

Rationale for this change

In an effort to prevent regressions creeping into the planner or optimizer, this PR adds tests for the expected plans for each benchmark query.

What changes are included in this PR?

Tests

Are there any user-facing changes?

No

@andygrove andygrove requested a review from alamb October 11, 2022 00:39
@github-actions github-actions bot added the optimizer Optimizer rules label Oct 11, 2022
@github-actions github-actions bot removed the optimizer Optimizer rules label Oct 11, 2022
@andygrove andygrove requested review from Dandandan and yjshen October 11, 2022 00:43
@alamb
Copy link
Contributor

alamb commented Oct 11, 2022

Thanks @andygrove -- this is perfect

@alamb
Copy link
Contributor

alamb commented Oct 11, 2022

Will likely help with issues such as #3729

@andygrove
Copy link
Member Author

Thanks for the reviews @alamb and @yjshen

@andygrove andygrove merged commit a9ee674 into apache:master Oct 11, 2022
@andygrove andygrove deleted the benchmark-regression-tests branch October 11, 2022 13:13
@ursabot
Copy link

ursabot commented Oct 11, 2022

Benchmark runs are scheduled for baseline = e359f02 and contender = a9ee674. a9ee674 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants