-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support inlist for pre cast literal expression #3270
Conversation
@andygrove PTAL, this is a follow-up pr for #3031 |
Codecov Report
@@ Coverage Diff @@
## master #3270 +/- ##
==========================================
+ Coverage 85.92% 85.94% +0.02%
==========================================
Files 294 294
Lines 53442 53536 +94
==========================================
+ Hits 45919 46012 +93
- Misses 7523 7524 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @liukun4515
Benchmark runs are scheduled for baseline = 3effee8 and contender = a4e74c0. a4e74c0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
part of #3031
Rationale for this change
What changes are included in this PR?
Support the
InList
in thePreCastLitInComparisonExpressions
optimizer ruleAre there any user-facing changes?