Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add explain sql test for optimizer rule PreCastLitInComparisonExpressions #3320

Merged
merged 3 commits into from
Sep 2, 2022
Merged

add explain sql test for optimizer rule PreCastLitInComparisonExpressions #3320

merged 3 commits into from
Sep 2, 2022

Conversation

liukun4515
Copy link
Contributor

Which issue does this PR close?

add SQL level test for the #3270

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@liukun4515 liukun4515 marked this pull request as ready for review September 1, 2022 07:33
@github-actions github-actions bot added the core Core DataFusion crate label Sep 1, 2022
@waynexia waynexia mentioned this pull request Sep 1, 2022
Closed
alamb
alamb approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liukun4515

@andygrove
Copy link
Member

test failure caused by #3327

@liukun4515
Copy link
Contributor Author

Thanks @liukun4515

resolve the comments manually

@liukun4515 liukun4515 merged commit 3956fc2 into apache:master Sep 2, 2022
@liukun4515 liukun4515 deleted the inlist_follow_up branch September 2, 2022 01:12
@ursabot
Copy link

ursabot commented Sep 2, 2022

Benchmark runs are scheduled for baseline = e0a765d and contender = 3956fc2. 3956fc2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

kmitchener pushed a commit to kmitchener/arrow-datafusion that referenced this pull request Sep 4, 2022
@liukun4515 @kmitchener
add explain sql test for optimizer rule PreCastLitInComparisonExpress…
a53354f 
…ions (apache#3320)

* add inlist test for optimizer rule PreCastLitInComparisonExpressions

* fmt code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

@andygrove andygrove Awaiting requested review from andygrove

Assignees
No one assigned
Labels
core Core DataFusion crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liukun4515 @andygrove @ursabot @alamb