Add decimal support to substrait serde #5054
Conversation
andygrove
changed the title
There was a problem hiding this comment.
makes sense to me -- I found https://github.com/apache/arrow-datafusion/pull/5054/files?w=1 easier to review
|
Benchmark runs are scheduled for baseline = 14e153e and contender = 552eea7. 552eea7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
| @@ -579,6 +579,13 @@ pub fn to_substrait_rex( | |||
| ScalarValue::Boolean(Some(b)) => Some(LiteralType::Boolean(*b)), | |||
| ScalarValue::Float32(Some(f)) => Some(LiteralType::Fp32(*f)), | |||
| ScalarValue::Float64(Some(f)) => Some(LiteralType::Fp64(*f)), | |||
| ScalarValue::Decimal128(v, p, s) if v.is_some() => { | |||
There was a problem hiding this comment.
Is there any rule about using the little-endian or the big-endian for the substrait?
In the Arrow-rs, parquet and datafusion, the big-endian is the default encoding for the decimal.
cc @andygrove
Which issue does this PR close?
Part of #4897
Original PR: datafusion-contrib/datafusion-substrait#39
Rationale for this change
Applying PRs that were already merged in the original repo
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?