This repository has been archived by the owner on Jan 13, 2023. It is now read-only.
Add decimal literal #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nseekhao
force-pushed
the
add_decimal_literal
branch
from
7af8895
to
20aee69
Compare
andygrove
approved these changes
Dec 15, 2022
martin-g
reviewed
Dec 15, 2022
| @@ -576,6 +583,13 @@ pub async fn from_substrait_rex( | |||
| Some(LiteralType::Fp64(f)) => { | |||
| Ok(Arc::new(Expr::Literal(ScalarValue::Float64(Some(*f))))) | |||
| } | |||
| Some(LiteralType::Decimal(d)) => Ok(Arc::new(Expr::Literal(ScalarValue::Decimal128( | |||
| Some(std::primitive::i128::from_le_bytes( | |||
| d.value.clone().try_into().unwrap(), | |||
There was a problem hiding this comment.
Is it OK to call .unwrap() here ?
Wouldn't it be better to use ? instead and propagate the error ? The method returns Result<Arc<Expr>>.
IMO a library should never panic!
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Decimal128literal expression (producer, consumer, test)create_context()to explicitly set one column to typeDecimal128to test implementation