Use compute_op_dyn_scalar for datatime #5315
Conversation
|
cc @sunchao |
|
There are some test failures, I will look at it. |
| ScalarValue::Date32(v) => compute_op_dyn_scalar!($LEFT, v, $OP, $OP_TYPE), | ||
| ScalarValue::Date64(v) => compute_op_dyn_scalar!($LEFT, v, $OP, $OP_TYPE), | ||
| ScalarValue::Time32Second(v) => compute_op_dyn_scalar!($LEFT, v, $OP, $OP_TYPE), | ||
| ScalarValue::Time32Millisecond(v) => compute_op_dyn_scalar!($LEFT, v, $OP, $OP_TYPE), | ||
| ScalarValue::Time64Microsecond(v) => compute_op_dyn_scalar!($LEFT, v, $OP, $OP_TYPE), | ||
| ScalarValue::Time64Nanosecond(v) => compute_op_dyn_scalar!($LEFT, v, $OP, $OP_TYPE), | ||
| ScalarValue::TimestampSecond(v, _) => compute_op_dyn_scalar!($LEFT, v, $OP, $OP_TYPE), | ||
| ScalarValue::TimestampMillisecond(v, _) => compute_op_dyn_scalar!($LEFT, v, $OP, $OP_TYPE), | ||
| ScalarValue::TimestampMicrosecond(v, _) => compute_op_dyn_scalar!($LEFT, v, $OP, $OP_TYPE), | ||
| ScalarValue::TimestampNanosecond(v, _) => compute_op_dyn_scalar!($LEFT, v, $OP, $OP_TYPE), |
There was a problem hiding this comment.
The CI error is because dyn comparison kernels don't support datatime/interval/duration types yet. I'm adding it at apache/arrow-rs#3730.
There was a problem hiding this comment.
So we need to wait for the PR merged and released.
viirya
force-pushed
the
datetime_op_dyn_scalar
branch
from
efc5df8
to
11fa95b
Compare
|
Thanks for review. Merged. |
|
Benchmark runs are scheduled for baseline = a4b47d8 and contender = f68214d. f68214d is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #5314.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?