Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass booleans by value instead of by reference #5487

Merged
merged 4 commits into from
Mar 8, 2023
Merged

Pass booleans by value instead of by reference #5487

merged 4 commits into from
Mar 8, 2023

Conversation

maxburke
Copy link
Contributor

@maxburke maxburke commented Mar 6, 2023

Fixes #5486

@maxburke maxburke mentioned this pull request Mar 6, 2023
Closed
@github-actions github-actions bot added the core Core DataFusion crate label Mar 6, 2023
waynexia
waynexia approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me

@alamb
Copy link
Contributor

alamb commented Mar 7, 2023

Looks like this PR has a few tests that need to be updated to get Ci to pass

@alamb alamb merged commit 9e32de3 into apache:main Mar 8, 2023
@alamb
Copy link
Contributor

alamb commented Mar 8, 2023

Thanks @maxburke and @waynexia !

@ursabot
Copy link

ursabot commented Mar 8, 2023

Benchmark runs are scheduled for baseline = deeaa56 and contender = 9e32de3. 9e32de3 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@korowa korowa mentioned this pull request Mar 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynexia waynexia waynexia approved these changes

Assignees
No one assigned
Labels
core Core DataFusion crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pass boolean values by value instead of by reference.
4 participants
@maxburke @alamb @ursabot @waynexia