Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logical merge conflict -- hash_join tests with passing boolean by value #5531

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

korowa
Copy link
Contributor

@korowa korowa commented Mar 9, 2023

Which issue does this PR close?

--

Rationale for this change

Fixing tests after #5487 and #5490 were merged

What changes are included in this PR?

Join creation in one of test cases fixed

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the core Core DataFusion crate label Mar 9, 2023
@korowa korowa changed the title fixed hash_join tests after passing boolean by value fix: hash_join tests with passing boolean by value Mar 9, 2023
@korowa korowa mentioned this pull request Mar 9, 2023
Copy link
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackwener
Copy link
Member

quick merge it due to it cause error in main.

@jackwener jackwener merged commit 8a1cb7e into apache:main Mar 9, 2023
@ursabot
Copy link

ursabot commented Mar 9, 2023

Benchmark runs are scheduled for baseline = f5d23ff and contender = 8a1cb7e. 8a1cb7e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb changed the title fix: hash_join tests with passing boolean by value fix: logical merge conflict -- hash_join tests with passing boolean by value Mar 9, 2023
@andygrove andygrove added the bug Something isn't working label Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants