Implement Debug for ExecutionProps and VarProvider
#5489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Mar 6, 2023
| @@ -23,7 +23,7 @@ use crate::variable::VarProvider; | |||
| use arrow::datatypes::DataType; | |||
|
|
|||
| /// System variable | |||
| #[derive(Default)] | |||
| #[derive(Default, Debug)] | |||
There was a problem hiding this comment.
This shows an example of user code that must be changed
crepererum
approved these changes
Mar 7, 2023
alamb
changed the title
Debug for ExecutionPropsDebug for ExecutionProps and VarProvider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5488
Rationale for this change
See #5488
What changes are included in this PR?
#[derive(Debug)]forExecutionPropsDebugto theVarProvidertrait -- this is technically a breaking change, but I think it is an improvement in usabilityAre these changes tested?
Yes, unit test
Are there any user-facing changes?
Anyone who has implemented
VarProviderwill also have to now ensure they implement theDebugfor that struct