Implement Debug for ExecutionProps and VarProvider (#5489)

* Implement `Debug` for `ExecutionProps` * fix examples * fix test
apache · Mar 7, 2023 · 8d8b765 · 8d8b765
1 parent a6f4a77
commit 8d8b765
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 4 deletions.
diff --git a/datafusion/core/src/test/variable.rs b/datafusion/core/src/test/variable.rs
@@ -23,7 +23,7 @@ use crate::variable::VarProvider;
 use arrow::datatypes::DataType;
 
 /// System variable
-#[derive(Default)]
+#[derive(Default, Debug)]
 pub struct SystemVar {}
 
 impl SystemVar {
@@ -46,7 +46,7 @@ impl VarProvider for SystemVar {
 }
 
 /// user defined variable
-#[derive(Default)]
+#[derive(Default, Debug)]
 pub struct UserDefinedVar {}
 
 impl UserDefinedVar {

diff --git a/datafusion/physical-expr/src/execution_props.rs b/datafusion/physical-expr/src/execution_props.rs
@@ -29,7 +29,7 @@ use std::sync::Arc;
 /// done so during predicate pruning and expression simplification
 ///
 /// [`LogicalPlan`]: datafusion_expr::LogicalPlan
-#[derive(Clone)]
+#[derive(Clone, Debug)]
 pub struct ExecutionProps {
  pub query_execution_start_time: DateTime<Utc>,
  /// Providers for scalar variables
@@ -85,3 +85,13 @@ impl ExecutionProps {
  .and_then(|var_providers| var_providers.get(&var_type).map(Arc::clone))
  }
 }
+
+#[cfg(test)]
+mod test {
+ use super::*;
+ #[test]
+ fn debug() {
+ let props = ExecutionProps::new();
+ assert_eq!("ExecutionProps { query_execution_start_time: 1970-01-01T00:00:00Z, var_providers: None }", format!("{props:?}"));
+ }
+}
diff --git a/datafusion/physical-expr/src/var_provider.rs b/datafusion/physical-expr/src/var_provider.rs
@@ -30,7 +30,7 @@ pub enum VarType {
 }
 
 /// A var provider for @variable
-pub trait VarProvider {
+pub trait VarProvider: std::fmt::Debug {
  /// Get variable value
  fn get_value(&self, var_names: Vec<String>) -> Result<ScalarValue>;