Update dependencies: prost to 0.8 and tonic to 0.5 #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Aug 2, 2021
| @@ -218,8 +218,8 @@ where | |||
| let batch_flight_data: Vec<_> = batch | |||
| .map(|b| create_flight_iter(&b, &options).collect()) | |||
| .map_err(|e| from_arrow_err(&e))?; | |||
| for batch in &batch_flight_data { | |||
| send_response(&tx, batch.clone()).await?; | |||
| for batch in batch_flight_data.into_iter() { | |||
There was a problem hiding this comment.
I don't know why but this was causing a compiler error for me, so I fixed it to get the tests to all pass cleanly on my machine
This was referenced Aug 2, 2021
houqp
approved these changes
Aug 2, 2021
|
I am merging this one in to get CI back to green. Please let me know if there are any additional concerns which I will be happy to address |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #817
Rationale for this change
Examples are failing as they use an incompatible version of tonic/prost that came in with arrow 5.1.0 (apache/arrow-rs#560) which leads to failures on CI PRs such as https://github.com/apache/arrow-datafusion/pull/808/checks?check_run_id=3223418729
What changes are included in this PR?
Update dependencies: prost to 0.8 and tonic to 0.5
Are there any user-facing changes?
New version of dependent libraries