fix: Metadata.Equal comparison with keys in different order #571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
approved these changes
Nov 11, 2025
alamb
reviewed
Nov 11, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @zeroshade 🙏
I am not quite enough of a go expert to understand the code change, but the test changes make sense to me 👍
This was referenced Nov 11, 2025
jbonofre
approved these changes
Nov 11, 2025
Member
|
LGTM (FYI, it impacts arrow-java, see apache/arrow-java#908). |
Contributor
|
Quick question just for my edification; is it legal for there to be multiple entries for the same key in a Metadata? Was trying to figure out why it's not a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
fixes #565
What changes are included in this PR?
Fixing
Metadata.sortedIndicesto properly sort the key indicesAre these changes tested?
Yes, a unit test is added for this situation
Are there any user-facing changes?
No