Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-548: [Release][Docs] Publish docs to https://arrow.apache.org/java/current/ on release #569

Merged
merged 4 commits into from
Jan 30, 2025
Merged

GH-548: [Release][Docs] Publish docs to https://arrow.apache.org/java/current/ on release #569

merged 4 commits into from
Jan 30, 2025

Conversation

kou
Copy link
Member

@kou kou commented Jan 28, 2025

Fixes GH-548.

lidavidm
lidavidm approved these changes Jan 28, 2025
View reviewed changes
.github/workflows/rc.yml Outdated
@@ -537,7 +536,7 @@ jobs:
cd site
git config --global user.name 'github-actions[bot]'
git config --global user.email 'github-actions[bot]@users.noreply.github.com'
git commit -m "Publish documentation (${GITHUB_SHA})"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, but "documentation" is perfectly fine here!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! I'll revert this change!

(I'm not sure the difference in "docs", "document", "documents", "documentation", "documentations", ...)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs -> short for documentation or documents (confusingly...)
document -> 書類など
documents -> plural of document (but usually not used for documentation, even though docs is used as the short form of both...)
documentations -> I think this not used (though apparently not wrong, just very rare)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!

@kou
Copy link
Member Author

kou commented Jan 28, 2025

I'm testing this on my fork but I reached "secondary rate limit": https://github.com/kou/arrow-java/actions/runs/13002063515/job/36263848521#step:3:17

HTTP 403: You have exceeded a secondary rate limit. Please wait a few minutes before you try again. If you reach out to GitHub Support for help, please include the request ID 7043:1FF31E:472E88:4F6691:67984405. (https://uploads.github.com/repos/kou/arrow-java/releases/197056655/assets?label=&name=flight-sql-jdbc-core-18.2.0-sources.jar.sha256)

Can we merge this and try this in a real release process...?

@kou
Copy link
Member Author

kou commented Jan 30, 2025

Let's try this in a real release process.

@kou kou merged commit f6b4f98 into apache:main Jan 30, 2025
25 checks passed
@kou kou deleted the ci-release-docs branch January 30, 2025 04:28
@kou kou mentioned this pull request Jan 30, 2025
Merged
@lidavidm lidavidm added this to the 18.2.0 milestone Jan 30, 2025
@kou kou mentioned this pull request Feb 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidavidm lidavidm lidavidm approved these changes

@laurentgo laurentgo Awaiting requested review from laurentgo laurentgo is a code owner

@wgtmac wgtmac Awaiting requested review from wgtmac wgtmac is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
18.2.0
Development

Successfully merging this pull request may close these issues.

[Release][Docs] Publish docs to https://arrow.apache.org/java/current/ on release
2 participants
@kou @lidavidm