Skip to content

MINOR: Bump error_prone_core.version from 2.31.0 to 2.37.0 #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 28, 2025
Merged

MINOR: Bump error_prone_core.version from 2.31.0 to 2.37.0 #682

merged 3 commits into from
Mar 28, 2025

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 24, 2025 •
edited
Loading

Bumps error_prone_core.version from 2.31.0 to 2.37.0.
Updates com.google.errorprone:error_prone_annotations from 2.31.0 to 2.37.0

Release notes

Sourced from com.google.errorprone:error_prone_annotations's releases.

Error Prone 2.37.0

Changes:

  • The annotations that were previously in error_prone_type_annotations have been been merged into error_prone_annotations. error_prone_type_annotations is now deprecated, and will be removed in a future release.

New checks:

  • AssignmentExpression - The use of an assignment expression can be surprising and hard to read; consider factoring out the assignment to a separate statement.
  • IntFloatConversion - Detect calls to scalb that should be using the double overload instead
  • InvalidSnippet - Detects snippets which omit the : required for inline code.
  • JUnit4EmptyMethods - Detects empty JUnit4 @Before, @After, @BeforeClass, and @AfterClass methods.
  • MockIllegalThrows - Detects cases where Mockito is configured to throw checked exception types which are impossible.
  • NegativeBoolean - Prefer positive boolean names.
  • RuleNotRun - Detects TestRules not annotated with @Rule, that won't be run.
  • StringConcatToTextBlock - Replaces concatenated multiline strings with text blocks.
  • TimeInStaticInitializer - Detects accesses of the system time in static contexts.

Closed issues:

  • Propagate check flags in patch mode (#4699)
  • Fixes a crash in ComputeIfAbsentAmbiguousReference (#4736)
  • Show the field name in HidingField diagnostics (#4775)
  • Add support for jakarta annotations to some checks (#4782)
  • FloatingPointAssertionWithinEpsilonTest depends on default locale (#4815)
  • @InlineMe patching of Strings.repeat produces broken code (#4819)
  • Fix a crash in IdentifierName on unnamed (_) variables (#4847)
  • Fix a crash in ArgumentParameterSwap (#490)

Full changelog: google/error-prone@v2.36.0...v2.37.0

Error Prone 2.36.0

Changes:

  • Add new matcher interfaces to ErrorProneScanner for AST nodes introduced after Java 11 (e5fd194fa21ef9a01e8d4c72489906247aad81c8)
  • Fix compatibility with latest JDK 24 EA builds (google/error-prone@d67bc15)
  • Check that --should-stop=ifError=FLOW is set when using the -Xplugin integration (e71db1f369a9367f6f2db34c4fbd006b6d6238fd)

New checks:

Closed issues: #4633, #4646

Full changelog: google/error-prone@v2.35.1...v2.36.0

Error Prone 2.35.1

Error Prone's dependency on protobuf has been downgraded to 3.25.5 for this release.

... (truncated)

Commits
  • a453935 Release Error Prone 2.37.0
  • 81faa5a Update JDK versions in release.yml
  • 62086b7 Handle multiple arguments in thenThrow.
  • 7440ff1 In StringConcatToTextBlock, don't assume that string literals always have sou...
  • 04fe835 Adds type_annotations back but as a relocation to annotations
  • 1ad73c2 Handle yield in Reachability
  • b1b521f Sniff out the canonical constructor using detective work rather than a flag w...
  • 86e5c95 Optimization: Abort class scan in JUnit4TestNotRun if all suspicious method...
  • c139e7f [StatementSwitchToExpressionSwitch] for the return switch pattern, fix a bug ...
  • 296fb4e Hardcode BoxedPrimitiveEquality:ExemptStaticConstants = false.
  • Additional commits viewable in compare view

Updates com.google.errorprone:error_prone_core from 2.31.0 to 2.37.0

Release notes

Sourced from com.google.errorprone:error_prone_core's releases.

Error Prone 2.37.0

Changes:

  • The annotations that were previously in error_prone_type_annotations have been been merged into error_prone_annotations. error_prone_type_annotations is now deprecated, and will be removed in a future release.

New checks:

  • AssignmentExpression - The use of an assignment expression can be surprising and hard to read; consider factoring out the assignment to a separate statement.
  • IntFloatConversion - Detect calls to scalb that should be using the double overload instead
  • InvalidSnippet - Detects snippets which omit the : required for inline code.
  • JUnit4EmptyMethods - Detects empty JUnit4 @Before, @After, @BeforeClass, and @AfterClass methods.
  • MockIllegalThrows - Detects cases where Mockito is configured to throw checked exception types which are impossible.
  • NegativeBoolean - Prefer positive boolean names.
  • RuleNotRun - Detects TestRules not annotated with @Rule, that won't be run.
  • StringConcatToTextBlock - Replaces concatenated multiline strings with text blocks.
  • TimeInStaticInitializer - Detects accesses of the system time in static contexts.

Closed issues:

  • Propagate check flags in patch mode (#4699)
  • Fixes a crash in ComputeIfAbsentAmbiguousReference (#4736)
  • Show the field name in HidingField diagnostics (#4775)
  • Add support for jakarta annotations to some checks (#4782)
  • FloatingPointAssertionWithinEpsilonTest depends on default locale (#4815)
  • @InlineMe patching of Strings.repeat produces broken code (#4819)
  • Fix a crash in IdentifierName on unnamed (_) variables (#4847)
  • Fix a crash in ArgumentParameterSwap (#490)

Full changelog: google/error-prone@v2.36.0...v2.37.0

Error Prone 2.36.0

Changes:

  • Add new matcher interfaces to ErrorProneScanner for AST nodes introduced after Java 11 (e5fd194fa21ef9a01e8d4c72489906247aad81c8)
  • Fix compatibility with latest JDK 24 EA builds (google/error-prone@d67bc15)
  • Check that --should-stop=ifError=FLOW is set when using the -Xplugin integration (e71db1f369a9367f6f2db34c4fbd006b6d6238fd)

New checks:

Closed issues: #4633, #4646

Full changelog: google/error-prone@v2.35.1...v2.36.0

Error Prone 2.35.1

Error Prone's dependency on protobuf has been downgraded to 3.25.5 for this release.

... (truncated)

Commits
  • a453935 Release Error Prone 2.37.0
  • 81faa5a Update JDK versions in release.yml
  • 62086b7 Handle multiple arguments in thenThrow.
  • 7440ff1 In StringConcatToTextBlock, don't assume that string literals always have sou...
  • 04fe835 Adds type_annotations back but as a relocation to annotations
  • 1ad73c2 Handle yield in Reachability
  • b1b521f Sniff out the canonical constructor using detective work rather than a flag w...
  • 86e5c95 Optimization: Abort class scan in JUnit4TestNotRun if all suspicious method...
  • c139e7f [StatementSwitchToExpressionSwitch] for the return switch pattern, fix a bug ...
  • 296fb4e Hardcode BoxedPrimitiveEquality:ExemptStaticConstants = false.
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Mar 24, 2025
@dependabot dependabot bot mentioned this pull request Mar 24, 2025
Closed
@github-actions github-actions bot added this to the 18.3.0 milestone Mar 24, 2025
@dependabot dependabot bot force-pushed the dependabot/maven/error_prone_core.version-2.37.0 branch 2 times, most recently from 005db1d to 745f763 Compare March 24, 2025 14:21
@dependabot
MINOR: Bump error_prone_core.version from 2.31.0 to 2.37.0
8feeda9 
Bumps `error_prone_core.version` from 2.31.0 to 2.37.0.

Updates `com.google.errorprone:error_prone_annotations` from 2.31.0 to 2.37.0
- [Release notes](https://github.com/google/error-prone/releases)
- [Commits](google/error-prone@v2.31.0...v2.37.0)

Updates `com.google.errorprone:error_prone_core` from 2.31.0 to 2.37.0
- [Release notes](https://github.com/google/error-prone/releases)
- [Commits](google/error-prone@v2.31.0...v2.37.0)

---
updated-dependencies:
- dependency-name: com.google.errorprone:error_prone_annotations
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: com.google.errorprone:error_prone_core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/maven/error_prone_core.version-2.37.0 branch from 745f763 to 8feeda9 Compare March 24, 2025 14:59
@jbonofre jbonofre force-pushed the dependabot/maven/error_prone_core.version-2.37.0 branch from f530097 to 88c764f Compare March 24, 2025 17:14
@jbonofre
Copy link
Member

jbonofre commented Mar 24, 2025

It seems errorprone 2.37.0 is not happy with JDK11.
Checking if JDK11 is still supported by errorprone 2.37.0.

@jbonofre
Copy link
Member

jbonofre commented Mar 24, 2025

NB: I reproduce the same error with JDK11 on my laptop (JDK17 just works fine).

@jbonofre
Copy link
Member

jbonofre commented Mar 24, 2025

OK, confirmed here: https://errorprone.info/docs/installation

  • Error Prone 2.10.0 is the latest version to support running on JDK 8.
  • Error Prone 2.31.0 is the latest version to support running on JDK 11.

@lidavidm @kou I guess it's better to stay with error prone 2.31.0 with JDK 11 support right ? We will upgrade to Error Prone 2.37.0 (and beyond) when we will remove JDK 11 support. I propose to close this PR for now. Does it make sense for you ?

@kou
Copy link
Member

kou commented Mar 25, 2025

How about dropping support for JDK 11? (We need to bump major version for it.)

We have a discussion and issue for this:

@lidavidm
Copy link
Member

lidavidm commented Mar 25, 2025

I don't think adoption of JDK 17 is broad enough to drop it quite yet, even if Java 11 is technically EOL. Laurent's ideas there about requiring a newer Java version to build but targeting an older version for runtime would be better.

@lidavidm
Copy link
Member

lidavidm commented Mar 25, 2025

The other thing we could do is only enable the error-prone profile for JDK17 builds? JDK11 builds would just not use error-prone.

@jbonofre
Copy link
Member

jbonofre commented Mar 25, 2025

I like @lidavidm proposal: I propose to keep JDK11 and 17 for now, but disable error prone in JDK11 (profile).
If no objection, I'm updating this PR accordingly.

@kou
Copy link
Member

kou commented Mar 25, 2025

It makes sense. Let's use the approach!

@jbonofre
Copy link
Member

jbonofre commented Mar 27, 2025

@lidavidm @kou I updated this PR to enable error prone 2.37.0 only with JDK 17+

kou
kou approved these changes Mar 28, 2025
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lidavidm lidavidm merged commit dbcc81c into main Mar 28, 2025
27 checks passed
@lidavidm lidavidm deleted the dependabot/maven/error_prone_core.version-2.37.0 branch March 28, 2025 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kou kou kou approved these changes

@lidavidm lidavidm lidavidm approved these changes

@laurentgo laurentgo Awaiting requested review from laurentgo laurentgo is a code owner

@wgtmac wgtmac Awaiting requested review from wgtmac wgtmac is a code owner

@jbonofre jbonofre Awaiting requested review from jbonofre jbonofre is a code owner

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file java Pull requests that update Java code

Projects

None yet

Milestone

18.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jbonofre @kou @lidavidm