Skip to content

Commit

Permalink
Bugfix type instability in length(::Arrow.ToList) (#497)
Browse files Browse the repository at this point in the history 
Co-authored-by: Ben Baumgold <4933671+baumgold@users.noreply.github.com>
  • Loading branch information
@JoaoAparicio @baumgold
JoaoAparicio and baumgold authored Jan 30, 2024
1 parent 3712291 commit ac199b0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Project.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
name = "Arrow"
uuid = "69666777-d1a9-59fb-9406-91d4454c9d45"
authors = ["quinnj <quinn.jacobd@gmail.com>"]
version = "2.7.0"
version = "2.7.1"

[deps]
ArrowTypes = "31f734f8-188a-4ce0-8406-c8a06bd891cd"
Expand Down
2 changes: 1 addition & 1 deletion src/arraytypes/list.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ function ToList(input; largelists::Bool=false)
end

Base.IndexStyle(::Type{<:ToList}) = Base.IndexLinear()
Base.size(x::ToList) = (length(x.inds) == 0 ? 0 : x.inds[end],)
Base.size(x::ToList{T,S,A,I}) where {T,S,A,I} = (isempty(x.inds) ? zero(I) : x.inds[end],)

function Base.pointer(A::ToList{UInt8}, i::Integer)
chunk = searchsortedfirst(A.inds, i)
Expand Down

2 comments on commit ac199b0

@baumgold
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/100060

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v2.7.1 -m "<description of version>" ac199b0e377502ea0f1fa5ced7fda897a01b82a9
git push origin v2.7.1

Please sign in to comment.