Fix copy on DictEncode #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #102. The issue comes up because DataFrames constructor tries to make a copy of input columns by default when constructing; for DictEncode, it's just a wrapper to signal that a column should be copied, so we just make a shallow copy.
Codecov Report
@@ Coverage Diff @@
## main #111 +/- ##
==========================================
- Coverage 84.06% 84.03% -0.04%
==========================================
Files 23 23
Lines 2698 2699 +1
==========================================
Hits 2268 2268
- Misses 430 431 +1
Continue to review full report at Codecov.
|
tanmaykm
pushed a commit
to tanmaykm/arrow-julia
that referenced
this pull request
Apr 7, 2021
Fixes apache#102. The issue comes up because DataFrames constructor tries to make a copy of input columns by default when constructing; for DictEncode, it's just a wrapper to signal that a column should be copied, so we just make a shallow copy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102. The issue comes up because DataFrames constructor tries to
make a copy of input columns by default when constructing; for
DictEncode, it's just a wrapper to signal that a column should be
copied, so we just make a shallow copy.