Don't store table metadata globally #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #90. There's no need to store table metadata globally when we can just store it in the Table type itself and overload the `getmetadata`. This should avoid metadata bloat in the global store.
Codecov Report
@@ Coverage Diff @@
## main #165 +/- ##
==========================================
+ Coverage 81.30% 81.32% +0.01%
==========================================
Files 25 25
Lines 3012 3014 +2
==========================================
+ Hits 2449 2451 +2
Misses 563 563
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90. There's no need to store table metadata globally when we can
just store it in the Table type itself and overload the
getmetadata.This should avoid metadata bloat in the global store.