Warn when converting Arrow.Timestamps to Dates.DateTime or ZonedDateTime #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #166. The problem OP saw in the original issue was that we didn't have a proper `ArrowTypes.fromarrow` method defined for `Dates.DateTime` from `Arrow.Timestamp` with nanosecond precision, which is accurate in one sense because `Dates.DateTime` only supports up to millisecond precision. But better than just erroring when trying to access these values later, we now do the conversion anyway, which may be lossy, and issue a warning about the potentially lossy conversion. If > millisecond precision is needed, then users should pass `convert=false` and operate on the `Arrow.Timestamp` values directly for now.
Codecov Report
@@ Coverage Diff @@
## main #172 +/- ##
==========================================
+ Coverage 81.30% 81.36% +0.05%
==========================================
Files 25 25
Lines 3017 3021 +4
==========================================
+ Hits 2453 2458 +5
+ Misses 564 563 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #166. The problem OP saw in the original issue was that we didn't
have a proper
ArrowTypes.fromarrowmethod defined forDates.DateTimefrom
Arrow.Timestampwith nanosecond precision, which is accurate inone sense because
Dates.DateTimeonly supports up to millisecondprecision. But better than just erroring when trying to access these
values later, we now do the conversion anyway, which may be lossy, and
issue a warning about the potentially lossy conversion. If > millisecond
precision is needed, then users should pass
convert=falseand operateon the
Arrow.Timestampvalues directly for now.