Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure requested List type is requested on List getindex #182

Merged
merged 2 commits into from
Apr 23, 2021
Merged

Conversation

quinnj
Copy link
Member

@quinnj quinnj commented Apr 22, 2021

Fixes #167. Not tested yet.

@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #182 (1bbb187) into main (742ea4c) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
- Coverage   82.04%   82.01%   -0.03%     
==========================================
  Files          26       26              
  Lines        3119     3120       +1     
==========================================
  Hits         2559     2559              
- Misses        560      561       +1     
Impacted Files Coverage Δ
src/ArrowTypes/src/ArrowTypes.jl 97.29% <50.00%> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 742ea4c...1bbb187. Read the comment docs.

@quinnj quinnj merged commit 8fca1e0 into main Apr 23, 2021
@quinnj quinnj deleted the jq/lists branch April 23, 2021 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with Tables.rowtable when entries contain a vector of strings
1 participant