Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scopedenum for EnumX #444

Merged
merged 2 commits into from
May 25, 2023
Merged

Remove scopedenum for EnumX #444

merged 2 commits into from
May 25, 2023

Conversation

quinnj
Copy link
Member

@quinnj quinnj commented May 24, 2023

Successor to #309

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2023

Codecov Report

Merging #444 (fd24b41) into main (3008e7f) will increase coverage by 4.27%.
The diff coverage is 80.64%.

@@            Coverage Diff             @@
##             main     #444      +/-   ##
==========================================
+ Coverage   82.98%   87.25%   +4.27%     
==========================================
  Files          25       26       +1     
  Lines        3214     3209       -5     
==========================================
+ Hits         2667     2800     +133     
+ Misses        547      409     -138     
Impacted Files Coverage Δ
src/metadata/Flatbuf.jl 100.00% <ø> (ø)
src/metadata/File.jl 30.61% <33.33%> (ø)
src/eltypes.jl 86.05% <62.06%> (+1.02%) ⬆️
src/metadata/Message.jl 77.68% <62.50%> (+5.78%) ⬆️
src/metadata/Schema.jl 83.75% <91.66%> (+3.92%) ⬆️
src/FlatBuffers/FlatBuffers.jl 93.33% <100.00%> (+29.69%) ⬆️
src/arraytypes/arraytypes.jl 89.62% <100.00%> (+3.77%) ⬆️
src/arraytypes/bool.jl 88.70% <100.00%> (+3.22%) ⬆️
src/arraytypes/compressed.jl 100.00% <100.00%> (+9.30%) ⬆️
src/arraytypes/dictencoding.jl 75.58% <100.00%> (+2.32%) ⬆️
... and 8 more

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@quinnj quinnj requested a review from baumgold May 25, 2023 03:35
@quinnj quinnj merged commit ebf9fcf into main May 25, 2023
@quinnj quinnj deleted the jq-enumsx branch May 25, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants