Return SubArrays when possible for arrow list types #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #446 +/- ##
==========================================
+ Coverage 87.46% 87.49% +0.03%
==========================================
Files 26 26
Lines 3263 3271 +8
==========================================
+ Hits 2854 2862 +8
Misses 409 409
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
quinnj
commented
Jun 1, 2023
| (t1 === t2) || (return false) | ||
| tt1 = Base.nonmissingtype(t1) | ||
| tt2 = Base.nonmissingtype(t2) | ||
| if t1 == t2 || (tt1 <: AbstractVector && tt2 <: AbstractVector && eltype(tt1) == eltype(tt2)) |
There was a problem hiding this comment.
This is needed to loosen what we consider "equivalent schemas"; i.e. a column w/ eltype Vector{Int} is now "equal" to SubArray{Int, 1, ...}
|
@baumgold, this is ready to review if you have a moment. |
baumgold
approved these changes
Jun 2, 2023
| (t1 === t2) || (return false) | ||
| tt1 = Base.nonmissingtype(t1) | ||
| tt2 = Base.nonmissingtype(t2) | ||
| if t1 == t2 || (tt1 <: AbstractVector && tt2 <: AbstractVector && eltype(tt1) == eltype(tt2)) |
There was a problem hiding this comment.
This looks good to me. Small nit-pick... small simplification without the continue:
t1 != t2 && (tt1 <: AbstractVector && tt2 <: AbstractVector && eltype(tt1) != eltype(tt2)) && return false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.