Fix case where compressed file reports non-zero buffer length #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #437. Thanks to @DrChainsaw for the investigation, proposed fix, and test file.
Codecov Report
@@ Coverage Diff @@
## main #448 +/- ##
=======================================
Coverage 87.49% 87.49%
=======================================
Files 26 26
Lines 3271 3271
=======================================
Hits 2862 2862
Misses 409 409
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
baumgold
reviewed
Jun 3, 2023
| len = unsafe_load(convert(Ptr{Int64}, ptr)) | ||
| len == 0 && return 0, UInt8[] |
There was a problem hiding this comment.
Maybe we should use iszero instead?
Suggested change
| len == 0 && return 0, UInt8[] | |
| iszero(len) && return 0, UInt8[] |
| if buffer.length == 0 | ||
| return 0, UInt8[] | ||
| end | ||
| buffer.length == 0 && return 0, UInt8[] |
There was a problem hiding this comment.
maybe we should use iszero instead?
Suggested change
| buffer.length == 0 && return 0, UInt8[] | |
| iszero(buffer.length) && return 0, UInt8[] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #437. Thanks to @DrChainsaw for the investigation, proposed fix, and test file.