Fix case of recursively nested lists #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thx for the swift fix |
Closed
Codecov Report
@@ Coverage Diff @@
## main #459 +/- ##
==========================================
- Coverage 87.55% 4.94% -82.62%
==========================================
Files 26 25 -1
Lines 3271 3194 -77
==========================================
- Hits 2864 158 -2706
- Misses 407 3036 +2629
... and 23 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
what happened to coverage 😆 |
I think it's getting confused w/ ArrowTypes.jl CI jobs finishing first and then we're getting 0 coverage on Arrow.jl files from ArrowTypes tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue reported by @Moelf in #458.
The issue is we need to get the eltype from the recursively built child array instead of as a top-level translation of the current field type.