Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that ArrowTypes.default is defined for Vararg tuples #466

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Commits on Jun 13, 2023

  1. Ensure that ArrowTypes.default is defined for Vararg tuples

    Fixes #461. This is the other proposal from what I originally suggested.
    Though `Tuple{Varag}` is never the concrete type of a value in Julia,
    it comes up when dealing with structs with fields that have Vararg
    types; not common at all, but it's allowed and happens.
    
    The reflection code here is a little gross, but it seems to be what
    Base Julia uses in similar queries to see if a tuple has a vararg
    element. I've commented out the Arrow/runtests test for now until
    we bump another version and can then uncomment. Unit tests are
    added for ArrowTypes in the meantime.
    quinnj committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    b56063e View commit details
    Browse the repository at this point in the history