Use wkspawn from ConcurrentUtilities instead of Threads.spawn #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix #336. For more context, see the [same fix](JuliaData/CSV.jl@077e177) we made for this in CSV.jl. Basically, objects interpolated into or returned from spawned tasks can be unexpectedly kept alive long after the task has finished and the object should have been garbage-collected due to individual threads holding the most recent task as a reference. Using `@wkspawn` ensures tasks themselves don't hold references to any of these once they're done executing.
Closed
Codecov Report
@@ Coverage Diff @@
## main #469 +/- ##
==========================================
- Coverage 87.56% 87.50% -0.07%
==========================================
Files 26 26
Lines 3280 3280
==========================================
- Hits 2872 2870 -2
- Misses 408 410 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
baumgold
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #336.
For more context, see the same fix we made for this in CSV.jl.
Basically, objects interpolated into or returned from spawned tasks can be unexpectedly kept alive long after the task has finished and the object should have been garbage-collected due to individual threads holding the most recent task as a reference. Using
@wkspawnensures tasks themselves don't hold references to any of these once they're done executing.