Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility of schemas with nested types #504

Merged
merged 4 commits into from
May 5, 2024

Conversation

poncito
Copy link
Contributor

@poncito poncito commented Apr 11, 2024

Hi,

Here is a minimal example of the issue I've encountered.

 struct A
    x::Int
end

struct B
    a::A
end

v = [B(A(i)) for i =1:3]

io = IOBuffer()
Arrow.write(io, v; file=false)
seekstart(io)
Arrow.append(io, v) # throws

I don't know if this is really necessary, or if I'm not using this library properly, but this issue makes it difficult to append to arrow files with nested types.

Since I've only added more cases where the call to append can succeed, I do not think that this creates retro-compatibility issues.

Thanks for the review!

@poncito poncito changed the title Compatibility of schemas with inner types Compatibility of schemas with nested types Apr 11, 2024
test/runtests.jl Outdated Show resolved Hide resolved
@poncito
Copy link
Contributor Author

poncito commented Apr 30, 2024

thanks Ben!

@baumgold baumgold merged commit 64fc730 into apache:main May 5, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants