Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support forth-coming Decimal 32/64 bitwidths #525

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support forth-coming Decimal 32/64 bitwidths #525

wants to merge 1 commit into from

Conversation

quinnj
Copy link
Member

@quinnj quinnj commented Sep 8, 2024

No description provided.

@quinnj quinnj force-pushed the jq-new-decimal-widths branch from 2e56900 to 9256c8d Compare September 8, 2024 16:36
kou
kou approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Could you fix a format error?

https://github.com/apache/arrow-julia/actions/runs/10761498796/job/29840764444?pr=525#step:5:13

┌ Error: Some files have not been formatted !!!
src/eltypes.jl
└ @ Main none:6

test/testtables.jl
Comment on lines +105 to +107
zero(Arrow.Decimal{Int32(2),Int32(2),Int64}),
zero(Arrow.Decimal{Int32(2),Int32(2),Int64}),
zero(Arrow.Decimal{Int32(2),Int32(2),Int64}),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use Int64() not Int32() here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quinnj @kou