add ArrowTypes.default methods and tests for dates
#86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #86 +/- ##
==========================================
+ Coverage 83.52% 83.59% +0.07%
==========================================
Files 23 23
Lines 2664 2670 +6
==========================================
+ Hits 2225 2232 +7
+ Misses 439 438 -1
Continue to review full report at Codecov.
|
quinnj
approved these changes
Dec 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84
The issue is that e.g.
zero(Date) == Day(0)which is not aDate, so theArrowTypes.defaultfallback gives the wrong type here. So I added fallbacks and tests.I didn't really get how the tests are organized so I'm not sure I've added the tests in the right spot.