fix(python): Ensure generator does not raise StopIteration
#262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Jul 19, 2023
| @@ -894,8 +894,11 @@ cdef class ArrayStream: | |||
| return array | |||
|
|
|||
| def __iter__(self): | |||
| while True: | |||
| yield self.get_next() | |||
| try: | |||
There was a problem hiding this comment.
I think this is also the use case for yield from in Python
There was a problem hiding this comment.
Thanks! I just looked it up and my head is about to explode but it does sound cleaner/the thing we should be doing 🤯
There was a problem hiding this comment.
I was also refreshing my Python knowledge on this, and so it's actually in the __next__ method that a StopIteration needs to be raised, not in __iter__
So another way to implement this would be:
def __iter__(self):
return self
def __next__(self):
return self.get_next()
(but the current one works fine as well)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #258, the Python tests are failing! I'm not sure the details of why this started now, but
StopIterationwas being raised in a generator which should just return instead.