-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python): Add array creation/building from buffers #378
Merged
Merged
Changes from 4 commits
Commits
Show all changes
68 commits
Select commit
Hold shift + click to select a range
622465d
re-render readme
paleolimbot 3d36f97
tweak the Device Python wrapper
paleolimbot 23480d2
use memoryview's iterator where possible
paleolimbot 45b100f
more flexible buffer view
paleolimbot 6ff52bc
suggestsions
paleolimbot 693b0a8
buffer stuff compiling without error
paleolimbot a5cf096
working buffer
paleolimbot 19def06
make work with Python 3.8, maybe better checking of buffer flags
paleolimbot 778ebae
test some buffer things
paleolimbot b666fc3
more buffer tests
paleolimbot 2c322a5
more tests
paleolimbot d203cde
start on buffer/array builders
paleolimbot aa044ac
working on array thing
paleolimbot 712f471
fix array from pybuffer
paleolimbot 92f3132
writable buffers
paleolimbot 82dbece
a few tests
paleolimbot 63613ae
move tests
paleolimbot 6014a95
remove duplicate tests, tidy c_lib
paleolimbot 8b3d44d
fix empty array building
paleolimbot 3427e7f
fix buffer setting with empty
paleolimbot 6dd74f6
actually fix empty array
paleolimbot b24e743
fix doctests
paleolimbot f6b9e59
better error handling
paleolimbot 404da09
result -> code
paleolimbot a419807
builder tests
paleolimbot de3b550
document build from buffers
paleolimbot 8c57e06
factor out c_format_from_arrow_type
paleolimbot 181bc0e
from iterable
paleolimbot a82b5da
bitpacking
paleolimbot 08acfbc
test intervals
paleolimbot d26a4e3
coverage
paleolimbot 3833067
test coverage
paleolimbot 5974a5b
document changes
paleolimbot 34c8fea
better doc for buffer
paleolimbot 17f127c
better construct for c_array
paleolimbot 7ee63ec
unify buffer creation
paleolimbot a223952
consolidate c_buffer_from_iterable usage
paleolimbot cb31e64
maybe iterable support in c_array
paleolimbot 1a7e8b8
isort
paleolimbot a0d7c96
maybe support Python 3.8
paleolimbot 0058da7
clarify requested_schema behaviour
paleolimbot bee8bee
maybe fix pypy
paleolimbot 642e116
pre-commit
paleolimbot d297a6f
fix doctests
paleolimbot c98e0dc
better coverage of array constructor
paleolimbot 49199e2
coverage
paleolimbot a936a4b
use root na usage
paleolimbot 3171e1c
separate array and buffer tests
paleolimbot e49bbc3
isort
paleolimbot 2ced8aa
buffer protocol on CBufer
paleolimbot 459c5e4
remove set_xx methods
paleolimbot f97fc63
Update python/src/nanoarrow/c_lib.py
paleolimbot 16a22fa
Update python/src/nanoarrow/c_lib.py
paleolimbot b449a9f
Update python/src/nanoarrow/c_lib.py
paleolimbot ec7a42e
Update python/src/nanoarrow/c_lib.py
paleolimbot 823f552
requested_schema -> schema
paleolimbot 9ce4f6d
make setxx methods internal
paleolimbot 109231e
separate buffer and buffer builder
paleolimbot 44229e4
error for pybuffer + schema for now
paleolimbot 1b4c3c6
maybe better array/buffer
paleolimbot 87364f5
sort element vs. item maybe
paleolimbot d091b45
more element tests
paleolimbot c22d2d0
add requested_schema back in
paleolimbot 8bdb881
Update python/src/nanoarrow/c_lib.py
paleolimbot 10e0fb9
clarify comment
paleolimbot 0c46b76
fix typo
paleolimbot 05f104c
maybe fix array handling
paleolimbot a94f7fd
update language
paleolimbot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, this is a bit cryptic to me what this does / can help you with, but I am also not familiar with the tool or the compile_commands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave it out for now since it's probably just me who has to remember that command. If
build/compile_commands.json
is present, most editors "just work" with the .c/.cc./.h files without additional configuration.