Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Fix failing weekly jobs #603

Merged

Conversation

paleolimbot
Copy link
Member

@paleolimbot paleolimbot commented Sep 5, 2024

This PR:

  • Updates the integration test workflow to not cache a weekly build, which was failing with "no space left on device". It also runs more tests than are strictly necessary at the commit level (and takes slightly longer without the cached weekly build), so this PR makes it part of a weekly run instead.
  • Updates the alpine dockerfile to avoid a desc dependency, since this fails to install on s390x
  • Update two tests to account for a function that returns the value of errno (that might not be the same everywhere)

It also updates the weekly jobs for consistency:

  • Updates the weekly jobs to always run on the maint-** branches
  • Update all of them to cancel previous runs of the same workflow (because many of them have long-running jobs)

It doesn't fix IPC writing on big endian (a different kind of failure that I'll punt to another PR).

@paleolimbot paleolimbot changed the title chore(ci): Fix docker images that are failing to build chore(ci): Fix failing weekly jobs Sep 6, 2024
@paleolimbot paleolimbot marked this pull request as ready for review September 6, 2024 19:32
Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +49 to +50
# Don't cache here (building the image takes about the same amount of time
# as downloading on CI)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's probably because the base image is hosted on dockerhub (and pretty big iirc), in my experience things on ghcr.io have much better download characteristics. Though maybe the build is just that fast too ^^

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In any case, I moved it to a weekly job for now since it's a better fit for that suite (and either building or downloading is still >10 minutes) 🙂

.github/workflows/integration.yaml Outdated Show resolved Hide resolved
Co-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
@paleolimbot paleolimbot merged commit 43001a9 into apache:main Sep 11, 2024
58 of 64 checks passed
@paleolimbot paleolimbot deleted the docker-build-integration-verify-s390x branch September 14, 2024 03:39
@paleolimbot paleolimbot added this to the nanoarrow 0.6.0 milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants