chore: More reliable definition of C standard in CMakeLists #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assignUser
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Hm, the value of CMAKE_C_STANDARD is used when a new target is created to initialize the relevant target property. So your existing code should have worked, as afaik the variable is not immutable once set. Could it just have been a case of needing to clean the build tree?
Your solution looks ok otherwise, so if this works in your local case 🤷
|
My therory was that the |
|
Oh yeah 🤦 true! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some local update on my local machine resulted in nanoarrow not compiling because clang gave a warning for the C11 extensions in the flatcc generated code. I believe this was because the C standard had already been set to C99 at the beginning of the file, whereas the check to update it to C11 only happened after this had already been set.