Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Use ARCHERY_INTEGRATION_TEST_TARGET_LANGUAGES to reduce integration test matrix #611

Merged

Conversation

paleolimbot
Copy link
Member

@paleolimbot paleolimbot commented Sep 17, 2024

Thanks to apache/arrow#44062 , we can run fewer jobs in our integration test matrix (and benefit from better GitHub actions grouping!).

@paleolimbot
Copy link
Member Author

Thank you @kou!

@paleolimbot paleolimbot marked this pull request as ready for review September 17, 2024 16:33
@paleolimbot paleolimbot merged commit b3deaaf into apache:main Sep 17, 2024
7 checks passed
@paleolimbot paleolimbot deleted the ci-integration-use-target-language branch September 17, 2024 17:54
@paleolimbot paleolimbot added this to the nanoarrow 0.6.0 milestone Sep 17, 2024
@kou
Copy link
Member

kou commented Sep 18, 2024

Yay!
But we may rename it to ..._IMPLEMENTATIONS: apache/arrow#44156
I'll notify you when it's completed.

@kou
Copy link
Member

kou commented Sep 19, 2024

I've merged apache/arrow#44156 .
Could you use this?

diff --git a/docker-compose.yml b/docker-compose.yml
index 2fb86c9..bd651cb 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -54,7 +54,7 @@ services:
     volumes:
       - ${NANOARROW_DOCKER_SOURCE_DIR}:/arrow-integration/nanoarrow
     environment:
-      ARCHERY_INTEGRATION_TARGET_LANGUAGES: "nanoarrow"
+      ARCHERY_INTEGRATION_TARGET_IMPLEMENTATIONS: "nanoarrow"
     command:
       ["echo '::group::Build nanoarrow' &&
         conda run --no-capture-output /arrow-integration/ci/scripts/nanoarrow_build.sh /arrow-integration /build &&

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants