We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bitmap
Describe the bug
Noticed whilst testing #1230, the bitmask length validation confuses byte length and bit length.
This will allow bitmasks that are too short to pass ArrayData::try_new validation
ArrayData::try_new
To Reproduce
#[test] fn test_validate_bitmask_length() { let data = MutableBuffer::from_len_zeroed(9 * 4).into(); let nulls = MutableBuffer::new_null(1).into(); let err = ArrayData::try_new( DataType::Int32, 9, Some(9), Some(nulls), 0, vec![data], vec![], ) .unwrap_err() .to_string(); assert!( err.contains("null_bit_buffer size too small. got 1 needed 2"), "{}", err ) }
Expected behavior
The above test should pass
The text was updated successfully, but these errors were encountered:
Fix null bitmap length validation (apache#1231)
e4b8ddb
Bitmap::len
Bitmap::bit_len
Fix null bitmap length validation (#1231) (#1232)
0375e81
* Fix null bitmap length validation (#1231) * Reuse existing test
Successfully merging a pull request may close this issue.
Describe the bug
Noticed whilst testing #1230, the bitmask length validation confuses byte length and bit length.
This will allow bitmasks that are too short to pass
ArrayData::try_new
validationTo Reproduce
Expected behavior
The above test should pass
The text was updated successfully, but these errors were encountered: