Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make bounds configurable via builder when reading CSV #1327

Closed
gsserge opened this issue Feb 17, 2022 · 0 comments · Fixed by #1341
Closed

Make bounds configurable via builder when reading CSV #1327

gsserge opened this issue Feb 17, 2022 · 0 comments · Fixed by #1341
Labels
arrow Changes to the arrow crate bug good first issue Good for newcomers

Comments

@gsserge
Copy link
Contributor

gsserge commented Feb 17, 2022

Discovered in #1324 (comment)

ReaderBuilder for cvs has the bounds field, which is supposed to be configured via builder and then passed to Reader::from_csv_reader() in the ReaderBuilder::build() method. At the moment this is not the case.

The fix should include new ReaderBuilder::with_bounds() method and a change in ReaderBuilder::build() to correctly pass the configured bounds to Reader::from_csv_reader().
@gsserge gsserge added the bug label Feb 17, 2022
@gsserge gsserge mentioned this issue Feb 17, 2022
Merged
@alamb alamb added arrow Changes to the arrow crate good first issue Good for newcomers labels Feb 17, 2022
@HaoYang670 HaoYang670 mentioned this issue Feb 18, 2022
Closed
@gsserge gsserge changed the title Make bounds configurable via builder when reading cvs Make bounds configurable via builder when reading csv Feb 18, 2022
@gsserge gsserge mentioned this issue Feb 19, 2022
Merged
@alamb alamb changed the title Make bounds configurable via builder when reading csv Make bounds configurable via builder when reading CSV Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate bug good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make bounds configurable in csv ReaderBuilder
2 participants
@gsserge @alamb